Draft
Conversation
To make the listed exemplary projects accessible through tabbing navigation, the div which contains all of a given project's information was converted into a button. A button is focusable by default and fits better semantically than a div.
By replacing the rows of the accordion menu with buttons, they are now focusable. These rows are restyled with the new 'fake-div' css class, which replicates their previous appearance as divs.
|
Looks good, but is it still a work in progress? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue with archived projects not being selectable with the tab key. This change is an improvement to keyboard accessibility that makes the aforementioned projects focusable.